Improve Login Flow #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had the help message inside the error we are raising, but we really want to be logging that as that is where users will be looking for help. Inside the error we can just dump the entire response. This might be absurd and too much content, but it at least allows them to make decisions based on this if they want.
We currently raise a `UserWarning` when we fail auth which isn't very descriptive and doesn't tell us what actually failed.
This is a more accurate error for what is actually happening and lets us save the actual response in case the user wants to do something with it.
Esterni
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the login flow logging a bit more clear and raises a more accurate error to what is actually happening, while passing the response inside it so users can use it to make decisions if they like.